I ws trained as an Advanced Class1 Police driver and also motorcyclist.
I also have the 'Great I A M advanced certificate. I held a class1 PSV and Class 2 HGV licence as they were once known.
We were taught,as Hopkirk quite correctly states, approach a junction using brakes. Come to a halt.Engage handbrake and then select neutral gear.
When waiting at ATS (traffic lights). The car should be as described previously. The Car should have handbrake on and in neutral. The driver should be aware of ATS changes and then prepare to change into 1st or 2nd gear (as appropriate) and disengage handbrake before first checking quickly left and right plus rear view mirror.
Waiting at a ATS junction whilst in gear and riding the clutch with handbrake off is potentially very dangerous. Should an inattentive driver behind give you a rear shunt whilst in that condition the driver is likely to let out the clutch and the car to enter the junction due to momentum of impact. My son was told by some underqualified instructor not to bother with the Highway code and he was never taught a 3 point turn,hill start or reversing around a corner keeping close and parallel to the kerb. The standard of tuition and examination today is appaling